I got this message once on the PTR with no addons installed

Posted for Maldavia:

Taint issues with UIDropDownMenu.

Taint log and steps to reproduce, see:
http://nerdheaven.dk/~the_real/taint.txt

---

Q u o t e:
I got this message once on the PTR with no addons installed

---

Because the Blizzard_FeedbackUI addon is not secure.

This feature already helped me discover a place in one of my add-ons where I forgot a "local"...thanks!

---

Q u o t e:
I had it stickied, but nobody was looking at it. :)

---

Ah, does that sound familiar...

---

Q u o t e:


Can you post the taint log? We should fix the Blizzard_FeedbackUI so it doesn't block actions. :)

Thanks!

---

Sorry mate, I played around for a while and couldn't reproduce it.

I did discover another bug though, so it wasn't a total waste of time :D

(Posting on behalf of Maldivia of the EU community):

Would it be possible to add a temporary workaround, for the UIDropDownMenu taint spreading to the TargetFrame, by securecall()'ing the CloseDropDownMenus() call in TargetFrame_OnEvent()? This would take care of most of the taint spreading from the UIDropDownMenus to the TargetFrame, until a more permanent solution can be implemented (like the rewrite you mentioned).

can i just say, Slouken, that i love your avatar?

Arrr!


<shifts to Flight Form and heads back to CSF>

You remind me of my pirate costume I got for the festivities in game!

edit: Am I allowed to say *WOOT FIRST PAGE* in here?

There turns out to be a HUGE vulnerability in the UIOptions frame that I guess I'm going to have to code around with HookScript() or something for the time being, but I thought I'd bring it up...

One of my AddOns, HealThyself, changes the behavior of a checkbox in the UIOptionsFrame Basic Options section (the auto-selfcast toggle)...currently it does this by setting the .func and .setFunc fields in the button's entry in UIOptionsFrameCheckButtons. The only problem with this approach is that it taints the execution of UIOptionsFrame_Load, causing that function to taint about 40 other globals, including SHOW_TARGET_OF_TARGET_STATE, thereby preventing the ToT frame from showing up in combat.

I may be able to work around this, by allowing the stock code to set the value from the cvar as usual and then overriding it, or detaching the button from UIOptionsFrameCheckButtons entirely so that UIOptionsFrame_Load doesn't touch it at all...but it seems to me that changing about four lines of code would fix the problem, and I don't see much potential for exploits (although I could of course be missing something).

UIOptionsFrame.lua::269: (changed lines marked with a *)

function UIOptionsFrame_Load()

*	local button, string, mode;

	for index, value in pairs(UIOptionsFrameCheckButtons) do

		button = getglobal("UIOptionsFrameCheckButton"..value.index);

		string = getglobal("UIOptionsFrameCheckButton"..value.index.."Text");

*		local checked = nil;

		button.disabled = nil;

		if ( value.func ) then

*			checked = securecall(value.func());

...



UIOptionsFrame.lua::344: 

*	local function SetWithCallBack(entry)

*		if entry.setFunc then entry.setFunc(entry.value); end

*		return entry.setFunc

*	end

function UIOptionsFrame_Save()

	local mode;

	for index, value in pairs(UIOptionsFrameCheckButtons) do

		local button = getglobal("UIOptionsFrameCheckButton"..value.index);

		if ( button:GetChecked() ) then

			value.value = "1";

		else

			value.value = "0";

		end



*		if ( securecall(SetWithCallBackEntry, value) ) then

*			-- action was taken in securecall

		elseif ( value.uvar == "AUTO_LOOT_DEFAULT" ) then

Taint log is here: http://genjitsugames.com/HealThyself.taint.log

I'm hoping this is the correct thread to post this... I'm getting a very strange error with my addon, and I can't figure out why. All my addon does is replace the QuestLog and tracker, it doesn't modify any other UI elements. I've tested this problem with several addons installed, and with nothing but my quest log addon installed, same error either way. Here's what happens:

I open the spellbook to use a spell or ability on the first page of the General tab
Clicking the button for the spell/ability I get an error message that my addon has been blocked from performing a restricted function. Through the use of a debugging mod, I find that there is a tainted execution path involving CastSpell
If I click Ignore in the error box, I can make that error come up each time I click a button.
Here's where I get confused... if I click ANY tab on the SpellBook, even the General tab, which is the current one, I can then click on a spell/ability and it will work normally, no error.

So apparently I have unknowingly tainted something having to do with the CastSpell function (this is my first mod, so I wouldn't be surprised if I messed something up). But I have been over and over all of my code to make sure I didn't misspell something, everything is declared local that needs to be, etc. After reading this thread I tried removing the one drop down menu I have, just in case I was creating it wrong, but the error still exists.

I'm hoping someone here can give me some insight into what CastSpell is doing or using that pertains to quest functionality, or any other hints anyone may have as to why this could happen.

Edit: Forgot to mention, I did /console taintLog 1, restarted the game, logged in, recreated the error, exited the game, but no taint.log ever showed up.

Edit 2: After posting this, I figured out the piece of code causing the error, but now I just don't understand why. My main frame is called QuestGuru_QuestLogFrame, and in order for other quest related addons to work with my addon like they do with the standard quest log, I did setglobal("QuestLogFrame", QuestGuru_QuestLogFrame); If I comment out that line, my error goes away.

Links to the addons are helpful, even if it is something you did not release, a temp link works so that Slouken and crew can recreate the problem.

Second, the /console taintLog1 command is a feature that is currently on the PTR, not the live realms. Log on to the PTR and try to recreate your problem =)